http://bugs.freedesktop.org/show_bug.cgi?id=15730
Roland Scheidegger <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #4 from Roland Scheidegger <[EMAIL PROTECTED]> 2008-04-29 13:25:12
PST ---
Your analysis looks right. I think it's not a problem for tcl because it does
the dma flush anyway for each primitive.
In any case, I've pushed your suggested fix (though I've moved it up one
function as it could be problematic there too). I don't think there should be
any performance issue with this, since if there are _any_ state changes
R200_NEWPRIM (and hence the dma flush) would be called anyway - only in case of
all state being equal would it make a difference, but this probably shouldn't
happen too often (it should only happen if an app sets some state, then
reverting the state to the previous value without drawing anything in-between,
or setting irrelevant state). The alternative would be to use some interim
values, then checking those against the rmesa->state.x values to decide if the
R200_NEWPRIM is needed before setting the rmesa->state.x values, but it doesn't
seem worth the trouble (the state handling is probably no longer really
optimally efficient anyway).
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
