On Thu, 23 Oct 2008, Andrew Morton wrote:
>
> Given that all highmem-implementing archtiectures must use the same
> declaration here, we might as well put it into include/linux/highmem.h.
> Although that goes against current mistakes^Wcode.
>
> Does powerpc32 still implement highmem? It seems that way. You broke
> it, no?
This really shouldn't be in highmem.h AT ALL.
The whole point of that function has absolutely nothing to do with
highmem, and it *must* be useful on non-highmem configurations to be
appropriate.
So I'd much rather create a new <linux/kmap.h> or something. Or just
expose this from to <asm/fixmap.h> or something. Let's not confuse this
with highmem, even if the implementation _historically_ was due to that.
Linus
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
