On Tuesday, November 11, 2008 4:55 pm Eric Anholt wrote:
> On Tue, 2008-11-11 at 16:48 -0800, Jesse Barnes wrote:
> > On Tuesday, November 11, 2008 2:16 pm Jesse Barnes wrote:
> > > +struct drm_i915_gem_mmap_gtt {
> > > + /** Handle for the object being mapped. */
> > > + uint32_t handle;
> > > + uint32_t pad;
> > > + /**
> > > + * Fake offset to use for subsequent mmap call
> > > + *
> > > + * This is a fixed-size type for 32/64 compatibility.
> > > + */
> > > + uint64_t addr_ptr;
> > > + uint32_t flags;
> > > +};
> >
> > Damn, I left flags in (had it removed but not committed). It's not
> > actually necessary. I'll post an updated set with the libdrm stuff and
> > this fixed.
>
> addr_ptr should probably be called "offset" since it's not actually a
> pointer, right?
Yeah, I thought the same thing when I updated it, though it's not even really
an offset, more of an object map key... So I could do either offset or
map_key or whatever. Any preferences?
Jesse
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
