On Tue, Dec 9, 2008 at 5:27 PM, Ben Gamari <[EMAIL PROTECTED]> wrote: > On Tue, 2008-12-09 at 11:19 -0800, Dan Nicholson wrote: >> I just had a quick scan of the patch, but a couple things jumped out. >> >> - The debugfs code should be conditional on CONFIG_DEBUG_FS. >> - // C++ comments >> - Some of the lowlevel *__*_info functions now only return 0. Could >> these be converted to void instead? >> >> -- >> Dan > > Here's a new patch to correct those few items. I'm not exactly sure if I > conditional-ized the debugfs code correctly. I also added a Kconfig item > for the debugfs interface.
I was thinking more that if you had CONFIG_DEBUG_FS, you should just get the code, rather than adding a new Kconfig item. But it doesn't look like many of the other drivers actually bother with that, so maybe it's all overkill. -- Dan ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
