On Thursday, January 8, 2009 5:25 pm Ian Romanick wrote:
> On Thu, Jan 08, 2009 at 10:45:16AM -0800, Jesse Barnes wrote:
> > Dunno if this is a good idea or not, but it would have helped with some
> > of the recent bugs.
> >
> > --
> > Jesse Barnes, Intel Open Source Technology Center
> >
> > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> > index 1e787f8..8ae2a6a 100644
> > --- a/drivers/gpu/drm/drm_irq.c
> > +++ b/drivers/gpu/drm/drm_irq.c
> > @@ -531,8 +542,11 @@ int drm_wait_vblank(struct drm_device *dev, void
> > *data,
> >
> > ret = drm_vblank_get(dev, crtc);
> > if (ret) {
> > - DRM_ERROR("failed to acquire vblank counter, %d\n", ret);
> > - return ret;
> > + DRM_ERROR("failed to acquire vblank counter, %d, assuming to
> > other
> > pipe\n", ret);
>
> I don't know what "assuming to other pipe" means. Maybe "trying other
> pipe"?
"assuming you meant the other pipe" but less wordy. "Trying other pipe" is
probably better.
>
> > + crtc = !crtc;
> > + ret = drm_vblank_get(dev, crtc);
> > + if (ret)
> > + return ret;
>
> Shouldn't there also be an error message here?
If userspace gets this wrong as often as it has in the past then that'll get
noisy real fast... OTOH nagging people to fix their installs might be a good
idea.
--
Jesse Barnes, Intel Open Source Technology Center
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
