On Sun, Jan 11, 2009 at 9:19 PM, Ralf Baechle <r...@linux-mips.org> wrote:
> On Sat, Jan 10, 2009 at 07:16:22PM +0100, Martin Michlmayr wrote:
>
>> Your patch "drm: Add GEM ("graphics execution manager") to i915
>> driver" [1] broke compilation on MIPS because agp.h doesn't exist.
>>
>> CALL scripts/checksyscalls.sh
>> CC [M] drivers/gpu/drm/drm_agpsupport.o
>> drivers/gpu/drm/drm_agpsupport.c:36:21: error: asm/agp.h: No such file or
>> directory
>> make[3]: *** [drivers/gpu/drm/drm_agpsupport.o] Error 1
>>
>> [1]
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=673a394b1e3b69be886ff24abfd6df97c52e8d08
>
> In drivers/gpu/drm/Kconfig:
>
>> menuconfig DRM
>> tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI
>> support)"
>> depends on (AGP || AGP=n) && PCI && !EMULATED_CMPXCHG && MMU
>
> (AGP || AGP=n) is looking fishy. What is the intend here?
>
>> select I2C
>> select I2C_ALGOBIT
>
> Shouldn't these be selected by the individual drivers?
>
> Some drivers further down the same config file have "depends on DRM" though
> they afaik are only PCI. Yet the AGP code will be built and there might
> not be any AGP support in such a system ...
>
We are just missing an ifdef around the asm/agp.h include I would guess.
If you don't have AGP support it shouldn't be included.
Dave.
> Ralf
>
> ------------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It is the best place to buy or sell services for
> just about anything Open Source.
> http://p.sf.net/sfu/Xq1LFB
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
