On Sun, Jan 18, 2009 at 4:56 PM, Jaswinder Singh Rajput <[email protected]> wrote: > On Sun, 2009-01-18 at 16:28 +0100, Hannes Eder wrote: >> Fix this sparse warnings: >> >> drivers/gpu/drm/drm_crtc_helper.c:137:6: warning: symbol >> 'drm_helper_probe_connector_modes' was not declared. Should it be static? >> drivers/gpu/drm/drm_modes.c:360:6: warning: symbol >> 'drm_mode_validate_clocks' was not declared. Should it be static? >> >> Signed-off-by: Hannes Eder <[email protected]> >> --- >> drivers/gpu/drm/drm_crtc_helper.c | 6 +++--- >> drivers/gpu/drm/drm_modes.c | 7 +++---- >> 2 files changed, 6 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c >> b/drivers/gpu/drm/drm_crtc_helper.c >> index d8a982b..a0b2601 100644 >> --- a/drivers/gpu/drm/drm_crtc_helper.c >> +++ b/drivers/gpu/drm/drm_crtc_helper.c >> @@ -134,8 +134,9 @@ void drm_helper_probe_single_connector_modes(struct >> drm_connector *connector, >> } >> EXPORT_SYMBOL(drm_helper_probe_single_connector_modes); >> >> -void drm_helper_probe_connector_modes(struct drm_device *dev, uint32_t maxX, >> - uint32_t maxY) >> +static void drm_helper_probe_connector_modes(struct drm_device *dev, >> + uint32_t maxX, >> + uint32_t maxY) >> { >> struct drm_connector *connector; >> >> @@ -143,7 +144,6 @@ void drm_helper_probe_connector_modes(struct drm_device >> *dev, uint32_t maxX, >> drm_helper_probe_single_connector_modes(connector, maxX, maxY); >> } >> } >> -EXPORT_SYMBOL(drm_helper_probe_connector_modes); >> > > hmm, what you are trying to do ? > >> >> /** >> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c >> index 7c36f16..c0cfe39 100644 >> --- a/drivers/gpu/drm/drm_modes.c >> +++ b/drivers/gpu/drm/drm_modes.c >> @@ -357,9 +357,9 @@ EXPORT_SYMBOL(drm_mode_validate_size); >> * sure each mode falls within a given range (defined by @min and @max >> * arrays) and sets @mode->status as needed. >> */ >> -void drm_mode_validate_clocks(struct drm_device *dev, >> - struct list_head *mode_list, >> - int *min, int *max, int n_ranges) >> +static void drm_mode_validate_clocks(struct drm_device *dev, >> + struct list_head *mode_list, >> + int *min, int *max, int n_ranges) >> { >> struct drm_display_mode *mode; >> int i; >> @@ -376,7 +376,6 @@ void drm_mode_validate_clocks(struct drm_device *dev, >> mode->status = MODE_CLOCK_RANGE; >> } >> } >> -EXPORT_SYMBOL(drm_mode_validate_clocks); > > ??
In both cases: a grep over the entire kernel tree shows that the function is only used within the compilation unit it is defined, therefore make it static and un-EXPORT it. Hannes ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
