From: Arnd Bergmann <a...@arndb.de> Date: Thu, 19 Feb 2009 15:19:01 +0100
> On Wednesday 18 February 2009, David Miller wrote: > > drm: Only use DRM_IOCTL_UPDATE_DRAW compat wrapper for compat X86. > > > > Only X86 32-bit uses a different alignment for "unsigned long long" > > than it's 64-bit counterpart. > > > > Therefore this compat translation is only correct, and only needed, > > when either CONFIG_X86 or CONFIG_IA64. > > > > Signed-off-by: David S. Miller <da...@davemloft.net> > > The patch is correct AFAICT, but I'd like to point out that the > problem could have been avoided (besides using a non-padded layout) > by using a compat_u64 member in the struct definition instead of > the packed attribute: Indeed, David A. showed me compat_u64 et al. and I'm fine with it being fixed that way too. Feel free to submit a patch :) ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
