On Thu, 2009-02-26 at 14:35 -0800, Jesse Barnes wrote:
> > > + ret = i915_gem_object_pin(obj, 0);
> > > + if (ret) {
> > > + DRM_ERROR("failed to pin object for flip\n");
> > > + ret = -EBUSY;
> >
> > What's the rationale for changing the reported error here? (And it might
> > be helpful to printk the original error value.)
>
> Oh I'm not sure what's going on there; I've changed it to just return the pin
> failure.
>
> > > + * Put the object in the GTT domain before the flip,
> > > + * since there may be outstanding rendering
> > > + */
> > > + i915_gem_object_set_to_gtt_domain(obj, 0);
> >
> > Need to check, report and handle errors here. And yes, these do occur in
> > the wild for some as of yet unknown reason.
>
> Fixed. Though Mesa is now flushing before calling the server so it should
> happen less often.
I found the source of the errors - ERESTARTSYS, so presumably we need to
add
if (ret == -ERESTARTSYS) ret = -EINTR;
handling here (after pining and flushing)?
-ickle
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
