Jerome Glisse wrote:
> Thomas there is 2 more bugs:
>
> In ttm_bo_mmap if the bo = NULL after ttm_bo_vm_lookup_rb
> then
> if (unlikely(bo == NULL)) {
> printk(KERN_ERR "Could not find buffer object to map.\n");
> goto out_unref;
> }
> Should be
> if (unlikely(bo == NULL)) {
> printk(KERN_ERR "Could not find buffer object to map.\n");
> return -EINVAL;
> }
> Otherwise you unref a null bo and bad things happen.
>
> In ttm_mem_reg_is_pci i think it should return false if
> flags TTM_MEMTYPE_FLAG_NEEDS_IOREMAP is not set otherwise
> kmap on a gart (unmappable to cpu) will think it needs
> to use ioremap which fails.
>
> Cheers,
> Jerome Glisse <gli...@freedesktop.org>
>
Thanks, Jerome.
I'll take a look at these.
/Thomas
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
