http://bugzilla.kernel.org/show_bug.cgi?id=12900





--- Comment #1 from Daniel Vetter <dan...@ffwll.ch>  2009-03-25 12:00:15 ---
Hi Jesse,

I started at the patch for a while, reverted various chunks and finally found
the problem. When I reverted the following lines (on top of recent -linus),
everything (glxgears in kms and non-kms ddx) works again:

--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -186,12 +186,12 @@
#define FENCE_REG_830_0                        0x2000
#define   I830_FENCE_START_MASK                0x07f80000
#define   I830_FENCE_TILING_Y_SHIFT    12
-#define   I830_FENCE_SIZE_BITS(size)   ((get_order(size >> 19) - 1) << 8)
+#define   I830_FENCE_SIZE_BITS(size)   ((ffs((size) >> 19) - 1) << 8)
#define   I830_FENCE_PITCH_SHIFT       4
#define   I830_FENCE_REG_VALID         (1<<0)

#define   I915_FENCE_START_MASK                0x0ff00000
-#define   I915_FENCE_SIZE_BITS(size)   ((get_order(size >> 20) - 1) << 8)
+#define   I915_FENCE_SIZE_BITS(size)   ((ffs((size) >> 20) - 1) << 8)

#define FENCE_REG_965_0                        0x03000
#define   I965_FENCE_PITCH_SHIFT       2

I'm using this now with kms to write this comment, so it seems to not have any
bad effects. Does that help in tracking down the root cause of these tiling
problems?

-Daniel

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to