On Wed, Apr 22, 2009 at 6:52 PM, Dave Airlie <airl...@gmail.com> wrote:
> From: Dave Airlie <airl...@linux.ie>
>
> On radeon at least this seems to solve a lot of our monitor misdetections.
>
> I suppose its possible if we are the end of a jiffy interval and we don't
> have 2.2ms left we could timeout early.

NAK (my own patch)

The proper fix is in the i2c core, I've sent a patch for it and asked
for it in stable as well.

Dave.

>
> Signed-off-by: Dave Airlie <airl...@redhat.com>
> ---
>  drivers/gpu/drm/i915/intel_i2c.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_i2c.c 
> b/drivers/gpu/drm/i915/intel_i2c.c
> index 5ee9d4c..20df92f 100644
> --- a/drivers/gpu/drm/i915/intel_i2c.c
> +++ b/drivers/gpu/drm/i915/intel_i2c.c
> @@ -144,7 +144,9 @@ struct intel_i2c_chan *intel_i2c_create(struct drm_device 
> *dev, const u32 reg,
>        chan->algo.getsda = get_data;
>        chan->algo.getscl = get_clock;
>        chan->algo.udelay = 20;
> -       chan->algo.timeout = usecs_to_jiffies(2200);
> +       /* use 2 jiffies even though vesa mandate 2.2ms,
> +        * as there seems to be an issue with a single jiffy */
> +       chan->algo.timeout = 2;
>        chan->algo.data = chan;
>
>        i2c_set_adapdata(&chan->adapter, chan);
> --
> 1.6.0.6
>
>
> ------------------------------------------------------------------------------
> Stay on top of everything new and different, both inside and
> around Java (TM) technology - register by April 22, and save
> $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
> 300 plus technical and hands-on sessions. Register today.
> Use priority code J9JMT32. http://p.sf.net/sfu/p
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>

------------------------------------------------------------------------------
Crystal Reports &#45; New Free Runtime and 30 Day Trial
Check out the new simplified licensign option that enables unlimited
royalty&#45;free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to