On Fri, May 1, 2009 at 10:19 PM, Jesse Barnes <jbar...@virtuousgeek.org> wrote: > On Wed, 29 Apr 2009 18:02:59 -0700 > Jesse Barnes <jbar...@virtuousgeek.org> wrote: > >> On Wed, 29 Apr 2009 15:09:33 -0700 >> Jesse Barnes <jbar...@virtuousgeek.org> wrote: >> > I'm still working through mutlihead issues on the kernel side; the >> > flip waits should wait for *both* vblank events before completing >> > the flip. But other than that, I'm pretty happy with things. >> >> This incremental set fixes up the multihead handling and adds swap >> interval support as a bonus. It's nice to see flipping & no tearing >> on two heads at once! > > Here's an update that makes all the code generic. Jakob suggested that > we do the mode_set_base call out of the caller's context so we don't > block the caller waiting for the GTT domain transition (effectively > waiting until rendering finishes). I definitely want to do this, but > I'll have to add a way to communicate the necessary flip data from the > ioctl to the new work function.
Cool stuff Jesse. I'm starting to agree with what Kristian said on irc, that we should only support one pending flip per crtc in the begining and then move onto supporting more later on if needed. I do think that the user space parts of libdrm looks fine with the exception of some comments. +#define DRM_IOCTL_GEM_PAGE_FLIP DRM_IOW( 0xB0, struct drm_gem_page_flip) Don't you mean DRM_IOCTL_MODE_PAGE_FLIP? +#define DRM_PAGE_FLIP_WAIT (1<<0) /* block on previous page flip */ Isn't the comment wrong here? And if we go with the idea that we only support on pending flip, should we have some sort of flag to control if we should return -EBUSY or block until the pending flip has cleared and the flip and the calling flip has been added? Cheers Jakob. ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
