On Tue, 2009-05-05 at 11:17 -0700, Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > yakui_zhao wrote: > > Add the CVT algorithm in kernel space. And this function can be called to > > generate the required modeline. > > > > Signed-off-by: Zhao Yakui <yakui.z...@intel.com> > > --- > > drivers/gpu/drm/drm_modes.c | 210 > > ++++++++++++++++++++++++++++++++++++++++++++ > > include/drm/drm_crtc.h | 3 > > 2 files changed, 213 insertions(+) > > > > Index: linux-2.6/drivers/gpu/drm/drm_modes.c > > =================================================================== > > --- linux-2.6.orig/drivers/gpu/drm/drm_modes.c 2009-04-21 > > 15:48:52.000000000 +0800 > > +++ linux-2.6/drivers/gpu/drm/drm_modes.c 2009-05-05 11:22:09.000000000 > > +0800 > > @@ -59,6 +59,216 @@ > > } > > EXPORT_SYMBOL(drm_mode_debug_printmodeline); > > > > +#define HV_FACTOR 1000 > > +/**************************************************************** > > + * Function : drm_cvt_mode > > + * > > + * Parameters : dev -drm device > > + * hdisplay - hdisplay size > > + * vdisplay - vdisplay size > > + * vfresh - vfresh rate. > > + * reduced - whether GTF calculation is simplified > > + * interlaced -- whether the interlace is supported > > + * Returns : return the display mode > > + * > > + * Function description > > + * : create the display mode according to the CVT > > algorthim. > > + * It is based on the file of > > xserver/hw/xfree86/modes/xf86cvt > > + */ > > Use kerneldoc function header comment style. I'd bet that Linus would > NAK this.
The existing style in the code is doxygen, and we've been continuing to use that so far. But coming up with your own new style is clearly wrong. -- Eric Anholt e...@anholt.net eric.anh...@intel.com
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com
-- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
