http://bugs.freedesktop.org/show_bug.cgi?id=21609
Summary: [radeon-rewrite] Use correct texture format for RGB textures Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r300 AssignedTo: dri-devel@lists.sourceforge.net ReportedBy: otay...@redhat.com r300SetTexBuffer2 looks at the 'cpp' field of the radeon_renderbuffer to decide what radeon texture format (pp_txformat) to use. The cpp comes the dri2 getBuffers - (see radeon_common_context.c:radeon_update_renderbuffers()) and is 4 even for a depth-24 X server pixmap. I'll attach a patch that fixes the problem locally; it's definitely a safe fix since if the GLXPixmap was created with GLX_TEXTURE_FORMAT_EXT attribute of GLX_TEXTURE_FORMAT_RGB_EXT, it can only be bound to RGB textures and A should be fixed at 1. Is it the correct fix? As implemented in the Radeon DDX, the cpp value comes from drawable.bitsPerPixel, so is 32 for both xRGB and ARGB pixmaps. This seems reasonable (though the DRI2 spec doesn't define what cpp is!), so the patch is probably along the right lines as well - but may need some extension: - The cpp == 3 case then shouldn't occur, since it would reflect packed pixels, something that the hardware can't support. - The r100/r200 drivers have pretty much identical code paths that would need the same fix. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. ------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel