On Fri, 08 May 2009 10:27:49 +0100
Barry Scott <barry.sc...@onelan.co.uk> wrote:
> Jesse Barnes wrote:
>
> Why are you comparing booleans to TRUE and worse then negating the
> result?
>
> if( !noWait )
>
> Is clearer.
>
> - waitForVideoSync (s);
> + if (!(noWait == TRUE))
> + waitForVideoSync (s);
Oh and this double negative stuff is ugly too. I probably should have
made the variable doVsync or something and defaulted it to true unless
--no-wait was passed, then I could have just done if (doVsync) { .. }.
Anyway if someone wants to apply this I'd be happy to fix it up. FWIW
I'm running it on my desktop right now with the new options and it's
working nicely; no tearing or anything.
--
--
Jesse Barnes, Intel Open Source Technology Center
------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image
processing features enabled. http://p.sf.net/sfu/kodak-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
