Hi Jesse !

Haven't had much time to investigate the problem I've been talking to
you and David about but from what I can see in the code, we're probably
hitting this in drm_mmap_locked() in drm_vm.c :

        /* Check for valid size. */
        if (map->size < vma->vm_end - vma->vm_start)
                return -EINVAL;

Now, this won't do any good for example if the SAREA is 8K (which I
think is about that nowadays) and the machine PAGE_SIZE is 64K.

There is indeed a possible problem of allowing clients to map more than
the resource specifically specified in the map, so just removing that
test may not be the best approach though.

I would suggest maybe bumping the SAREA to be a multiple of the page
size for now. I think that should get us going. I'll have a go at a
patch on monday unless there's an objection. That won't help for things
like MMIO register space that isn't a multiple of the page size but
fortunately that won't be hitting my with radeon for now and we can deal
with that when we need to.

Any objection ?

Cheers,
Ben.



------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to