On Thu, 2009-06-11 at 14:16 -0700, Keith Packard wrote:
> For operations requiring GEM interfaces in the kernel, and which do not
> depend on whether the driver offers DRI2 to X applications.
> 
> I think I got all of the right tests, but additional eyeballs would be
> appreciated here.

[...]

> diff --git a/src/i830_display.c b/src/i830_display.c
> index a7eafb9..6cacbe8 100644
> --- a/src/i830_display.c
> +++ b/src/i830_display.c
> @@ -1045,7 +1045,7 @@ static void i830_modeset_ctl(xf86CrtcPtr crtc, int pre)
>      I830CrtcPrivatePtr intel_crtc = crtc->driver_private;
>      struct drm_modeset_ctl modeset;
>  
> -    if (pI830->directRenderingType <= DRI_NONE)
> +    if (!pI830->have_gem)
>        return;

The DRM_IOCTL_MODESET_CTL ioctl has nothing to do with GEM. It probably
shouldn't be called with KMS, but maybe i830_modeset_ctl() won't be
called in that case anyway.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to