On Sun, 2009-08-02 at 08:53 +1000, Dave Airlie wrote: > On Sun, Aug 2, 2009 at 12:48 AM, Jerome Glisse<gli...@freedesktop.org> wrote: > > > > I am working on patch to exercise this, i am especialy > > interested in performances improvement we can have in > > application which routinely call getimage for rendering, > > such as firefox.
BTW, such apps are really broken... GetImage is for things like screenshots, not for normal rendering paths. > two things > a) test with small VRAM/aperture sizes and make sure > aperture flushing works. > > b) you really need DFS for this not moving the buffer. > > You just want to copy the buffer contents out, and leave it where it > is if you can. > > For GetImage you don't want to migrate the buffer out of wherever it > is generally. > > I've already done this for F11, the F11 2D driver performs quite well. I agree, even without DFS/UTS it already works quite well for me. The only concern I have about the current scheme is that IIUC BOs may get stuck in GTT, because we basically specify that as a read domain everywhere. We may need some kind of mechanism for forcing BOs into VRAM 'after a while' even if the GPU only reads from them. E.g. if I specify only RADEON_GEM_DOMAIN_GTT for creating the BOs for textures in the 3D driver, texdown numbers go up but everything else goes down, because apparently the texture BOs stay in GTT. Of course, another solution for that particular problem would be to use separate BOs for glTex(Sub)Image and blit from that to the real one in VRAM. But I suspect BOs could get stuck in GTT in other circumstances, e.g. after there happened to be no space in VRAM when they were validated. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
