Maarten Maathuis wrote:
> - This appears to fix some of the graphical corruption issues i've been
> having.
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index ebc9532..a11a0dc 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1505,7 +1505,7 @@ retry_pre_get:
>
> write_lock(&bdev->vm_lock);
> bo->vm_node = drm_mm_search_free(&bdev->addr_space_mm,
> - bo->mem.num_pages, 0, 0);
> + bo->mem.num_pages,
> bo->mem.page_alignment, 0);
>
> if (unlikely(bo->vm_node == NULL)) {
> ret = -ENOMEM;
> @@ -1513,7 +1513,7 @@ retry_pre_get:
> }
>
> bo->vm_node = drm_mm_get_block_atomic(bo->vm_node,
> - bo->mem.num_pages, 0);
> + bo->mem.num_pages,
> bo->mem.page_alignment);
>
> if (unlikely(bo->vm_node == NULL)) {
> write_unlock(&bdev->vm_lock);
>
Maarten,
The page alignment shouldn't matter here since what's allocated is a
free slot within the device file address space. It's only used for cpu
map / write / read, and the GPU never sees the vm_node offset.
If this is indeed fixing your issue, then it's probably related to a bug
elsewhere, so I'm NAK-ing this until we know how this could fix the
graphical corruption. Enforcing unnecessary alignments here will
fragment the device file address space.
/Thomas
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
