Jesse Barnes wrote:
> On Fri, 14 Aug 2009 10:42:57 +0200
> Thomas Hellstrom <thellst...@vmware.com> wrote:
>
>
>> The drm sysfs class suspend / resume methods could not distinguish
>> between different device types wich could lead to illegal type casts.
>>
>> Use struct device_type and make sure the class suspend / resume
>> callbacks are aware of those. There is no per device-type suspend /
>> resume. Only new-style PM.
>> ---
>>
>
> Looks good aside from nitpicks:
>
>
>> +static struct device_type drm_sysfs_device_minor =
>> + {
>> + .name = "drm_minor"
>> +
>> + /**
>> + * New pm system goes here.
>> + */
>> +
>> + };
>> +
>>
>
> Unusual indentation here (I think the usual is
>
> struct foo bar {
> .baz = xyz,
> };
>
>
>> +
>> /* Display the version of drm_core. This doesn't work right in
>> current design */ static ssize_t version_show(struct class *dev, char
>> *buf) {
>>
>
> Stray whitespace?
>
>
Yes, Fixing and resending.
/Thomas
> Acked-by: Jesse Barnes <jbar...@virtuousgeek.org>
>
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
