On Thu, Dec 03, 2009 at 02:56:39PM +0100, Rafał Miłecki wrote: > Someone willing to review? >
I don't think this how we want to do thing, see my previous mail. To sumup -create workqueue with timeout -function which do the clock change and takes all lock necessary -function call from IRQ which call the previous function Now in the timeout function when you see you can downclock you ask for a vblank interrupt, thus next vblank interrupt the interrupt handler will call the downclock function and the downclock function by taking necessary lock will ensure no modesetting or cs activity occur while downclocking, if acquiring lock fail you should return doing nothing than rescheduling the PM workqueue. With such scheme you don't need to hook up into the dpms function which is a lot better from my POV. Also there is a corner case that the workqueue function must handle, no mode set thus no vblank interrupt, in that case you need to directly call the downclock function. Cheers, Jerome ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
