Jerome Glisse wrote: > This patch series add printing of all informations necessary to > understand why getting memory space fails. I have mixed feeling > on letting this enabled by default or only enabling it with debug > compile flags. > > Cheers, > Jerome > > Jerome, This is Acked-By me, although we should only enable it on debug, and remove the existing error message as well.
The reason for this is as follows: When we get an out of memory error, it may be due to conditions that we should recover from without error: 1) Concurrent memory manager use. (not applicable on Radeon since you use a single mutex for validation). The remedy for concurrent drivers is to take the validation lock in write mode to block concurrent users and retry. 2) Fragmentation. The remedy for this is to evict all evictable buffers and retry. When these two steps are tried and have failed, only then we should give an error message, and only the driver can do that. /Thomas ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
