On 2010.01.18 13:30:00 +0000, James Simmons wrote: > > > commit 731b5a15a3b1474a41c2ca29b4c32b0f21bc852e > > Author: James Simmons <jsimm...@infradead.org> > > Date: Thu Oct 29 20:39:07 2009 +0000 > > > > drm/kms: properly handle fbdev blanking > > > > uses DRM_MODE_DPMS_ON for FB_BLANK_NORMAL, but DRM_MODE_DPMS_ON > > is actually for turning output on instead of blank. > > > > This makes fb blank broken on my T61, it put LVDS on but leave > > pipe disabled which made screen totally white or caused some > > 'burning' effect. > > > > Cc: James Simmons <jsimm...@infradead.org> > > Signed-off-by: Zhenyu Wang <zhen...@linux.intel.com> > > --- > > drivers/gpu/drm/drm_fb_helper.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c > > b/drivers/gpu/drm/drm_fb_helper.c > > index 1c2b7d4..0f9e905 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -389,7 +389,7 @@ int drm_fb_helper_blank(int blank, struct fb_info *info) > > break; > > /* Display: Off; HSync: On, VSync: On */ > > case FB_BLANK_NORMAL: > > - drm_fb_helper_off(info, DRM_MODE_DPMS_ON); > > + drm_fb_helper_off(info, DRM_MODE_DPMS_STANDBY); > > break; > > /* Display: Off; HSync: Off, VSync: On */ > > case FB_BLANK_HSYNC_SUSPEND: > > Nak. The problem is the intel drm drivers doesn't handle it power > management state seperate from the encoder state.
drm_fb_helper_off() will find fb's crtc and attached encoders, then call encoder_funcs->dpms() and turn off crtc, so for your DRM_MODE_DPMS_ON change, it will actually turn encoder on, but what we need for FB_BLANK_NORMAL is to turn off the display. No? -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev
-- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
