On Mon, Feb 1, 2010 at 6:46 PM, Luca Barbieri <l...@luca-barbieri.com> wrote: >> Idea is to mask all move which involve TT (AGP) with the agp_caching_mask, >> it's easy to do in radeon ttm layer code and i believe it's easy to do >> in nouveau >> too. On non AGP you set agp_caching_mask to UC|WC|CACHED. > > Sure, but isn't that uglier and much more ad-hoc that the patch I proposed? >
Your patch remove the consistency of caching attribute and make move btw non fixed area different than others move, while driver can already achieve so. As i said others change in ttm which wouldn't change consistency can simplify the problem from the driver POV. I think it's better to avoid tweaking core ttm to fix issue your driver can fix by using already existing functionalities. That's my feeling. Cheers, Jerome ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
