[
https://issues.apache.org/jira/browse/DRILL-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605355#comment-13605355
]
David Alves commented on DRILL-46:
----------------------------------
I'll update the page wrt to junit and reviewboard.
With regard to pull requests (with patch extension) I think they are great for
WIP reviews but that we should refrain from using them for patches of any kind.
The reasoning is that, because the patch is dynamically generated based on the
curent diff, the pull requester could change the patch at any time after the
review and before the merge.
> Setup contributing page and coding style guidelines
> ---------------------------------------------------
>
> Key: DRILL-46
> URL: https://issues.apache.org/jira/browse/DRILL-46
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: David Alves
> Assignee: David Alves
> Priority: Minor
>
> Like most projects at apache Drill needs to have a coding style set up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
