> On April 23, 2013, 3:32 p.m., Jacques Nadeau wrote: > > sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/eval/EvaluatorTypes.java, > > line 51 > > <https://reviews.apache.org/r/10209/diff/1/?file=276550#file276550line51> > > > > I had made a coment here before that it might be worthwhile to extract > > out eval() and clear() rather than have a separate runningEval(). Did you > > see that comment and disagree or never see that comment?
It's been a while, but I think I remember reading that comment. I think what I was thinking at that time was that eval() is a much more common base method, so I'm hesitant to change its behavior since one of the callee might expect it to call clear(). What you think? - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10209/#review19584 ----------------------------------------------------------- On April 2, 2013, 8:26 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10209/ > ----------------------------------------------------------- > > (Updated April 2, 2013, 8:26 p.m.) > > > Review request for drill. > > > Description > ------- > > Added RunningAggregate Ref Impl > > > Diffs > ----- > > > sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/LogicalOperator.java > e2bda45 > > sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/RunningAggregate.java > 01df9a0 > > sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/eval/EvaluatorTypes.java > 2cb65ff > > sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/eval/fn/agg/AggregatingWrapperEvaluator.java > ab7358f > > sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/eval/fn/agg/CountAggregator.java > 099c001 > > sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/eval/fn/agg/SumAggregator.java > 63fe017 > > sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/rops/RunningAggregateROP.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10209/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
