[
https://issues.apache.org/jira/browse/DRILL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678347#comment-13678347
]
Ben Becker commented on DRILL-67:
---------------------------------
Hi Alexandre,
Just a few more notes from the DRILL-70-1.patch:
- AvgAggregator will overflow when counting above 2^52. Might want to
consider a moving average.
- inputHasFloat doesn't mean the min/max value was a float (consider the
dataset 1, 2.0, 3).
- reset() needs to set inputHasFloat back to false (this should have been in
my patch).
Thanks for all of your work on this!
Ben
> Add Min, Max, avg and others Aggregated function
> ------------------------------------------------
>
> Key: DRILL-67
> URL: https://issues.apache.org/jira/browse/DRILL-67
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Alexandre Beche
> Priority: Trivial
> Labels: patch
> Attachments: DRILL-67.patch.txt, DRILL-70-1.patch.txt,
> DRILL-70-feedback.diff, DRILL-70.patch.txt
>
>
> This proposed improvement is to add the MIN(), MAX() and AVG() function to
> the list of the aggregated function.
> SumAggregator will be used as an example.
> Others function could be added
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
