----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12960/#review24198 -----------------------------------------------------------
Generally looks good. Two small comments. Nice work Lisen! sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java <https://reviews.apache.org/r/12960/#comment48037> Isn't this a required condition? What is a union with no inputs? sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java <https://reviews.apache.org/r/12960/#comment48038> You probably shouldn't call kill if you've already successfully completed a reading a stream of batches. E.g. maybe only curent and iterator.next() batches should be killed. - Jacques Nadeau On July 26, 2013, 7:32 a.m., Lisen Mu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12960/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 7:32 a.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > union pop. > > > Diffs > ----- > > > sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractMultiple.java > PRE-CREATION > > sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java > f782325 > > sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java > f36633f > > sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Union.java > PRE-CREATION > > sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java > 7740955 > > sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionBatchCreator.java > PRE-CREATION > > sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java > PRE-CREATION > > sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java > PRE-CREATION > sandbox/prototype/exec/java-exec/src/test/resources/union/test1.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/12960/diff/ > > > Testing > ------- > > org.apache.drill.exec.physical.impl.union.TestSimpleUnion > > > Thanks, > > Lisen Mu > >
