DRILL-243: lowercase asc/desc in generated physical plans causes failures
Project: http://git-wip-us.apache.org/repos/asf/incubator-drill/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-drill/commit/c93a5a1d Tree: http://git-wip-us.apache.org/repos/asf/incubator-drill/tree/c93a5a1d Diff: http://git-wip-us.apache.org/repos/asf/incubator-drill/diff/c93a5a1d Branch: refs/heads/master Commit: c93a5a1dc396fc8378da77b62a9e61314fbc98b4 Parents: 5883d15 Author: Steven Phillips <[email protected]> Authored: Thu Sep 12 20:11:02 2013 -0700 Committer: Steven Phillips <[email protected]> Committed: Fri Sep 20 15:10:22 2013 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/drill/common/logical/data/Order.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-drill/blob/c93a5a1d/common/src/main/java/org/apache/drill/common/logical/data/Order.java ---------------------------------------------------------------------- diff --git a/common/src/main/java/org/apache/drill/common/logical/data/Order.java b/common/src/main/java/org/apache/drill/common/logical/data/Order.java index 1c7459f..7b77218 100644 --- a/common/src/main/java/org/apache/drill/common/logical/data/Order.java +++ b/common/src/main/java/org/apache/drill/common/logical/data/Order.java @@ -70,7 +70,7 @@ public class Order extends SingleInputOperator { public Ordering(@JsonProperty("order") String strOrder, @JsonProperty("expr") LogicalExpression expr, @JsonProperty("nullCollation") String nullCollation) { this.expr = expr; this.nulls = NullCollation.NULLS_LAST.description.equals(nullCollation) ? NullCollation.NULLS_LAST : NullCollation.NULLS_FIRST; // default first - this.direction = Direction.DESC.description.equals(strOrder) ? Direction.DESC : Direction.ASC; // default asc + this.direction = Direction.DESC.description.equalsIgnoreCase(strOrder) ? Direction.DESC : Direction.ASC; // default asc } @@ -105,7 +105,7 @@ public class Order extends SingleInputOperator { } public static enum Direction { - ASC("asc"), DESC("desc"); + ASC("ASC"), DESC("DESC"); public final String description; Direction(String d) {
