----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15186/#review28550 -----------------------------------------------------------
Ship it! I'll merge as is. Please file new JIRAs and patches to address two issues. exec/java-exec/src/main/java/org/apache/drill/exec/client/DumpCat.java <https://reviews.apache.org/r/15186/#comment55345> You should update this so that it uses a HDFS:// filesystem object rather than a java file object. exec/java-exec/src/main/java/org/apache/drill/exec/util/VectorUtil.java <https://reviews.apache.org/r/15186/#comment55346> Magic numbers (50, 17, 15) should really be set as static constants - Jacques Nadeau On Nov. 1, 2013, 7:29 p.m., Jinfeng Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15186/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 7:29 p.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > DRILL-266:Build tools to interpret the output dumped by the diagnostic > operator. > > It include the following changes: > > 1. A tool to interpret the output dumped by the diagnostic operator. > 2. A utility method to display the content of vector container, which is > shared by the dump tool and query submitter. > 3. Minor change to query submitter, to use the utility method. > > > Diffs > ----- > > distribution/src/assemble/bin.xml 26de847 > distribution/src/resources/drill_dumpcat PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/client/DumpCat.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/client/QuerySubmitter.java > 160ef7f > exec/java-exec/src/main/java/org/apache/drill/exec/util/VectorUtil.java > PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/exec/client/DumpCatTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15186/diff/ > > > Testing > ------- > > > Thanks, > > Jinfeng Ni > >
