-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14958/
-----------------------------------------------------------
(Updated Nov. 12, 2013, 12:31 a.m.)
Review request for drill.
Changes
-------
Use COMPARE_TO function generator instead of manually generating comparison
code.
Bugs: DRILL-229
https://issues.apache.org/jira/browse/DRILL-229
Repository: drill-git
Description
-------
Implements the merging receiver operator as described in DRILL-229.
Commit Log:
- Fix multi-batch bugs. Add human-readable test output.
- Fix recordCount and valueIndex off-by-one
- Implement manual comparison code generation. Manual approach was chosen
over modifying the ValueVectorReadExpression, EvalutionVisitor and
CodeGenerator to minimize special-case code in those classes.
- Implemented code gen for copying; comparison needs a materializer that works
on a RecordBatchLoader
- Flesh out the reset of the merging receiver and fix bugs. Next step is
generated code for comparator and copier.
- Implements support for RecordBatchLoader, VectorContainer and BatchSchema in
MergingRecordBatch Implements first-iteration specific logic WIP: Merge logic.
Some constructs are in place, others are temporary or only stubbed out)
- Add SingleMergeExchange, which constructs one receiver and many senders
(similar to UnionExchange)
- Implement stub for MergingRecordBatch
- Add test for MergingReceiver (leveraging SingleMergeExchange)
s/MergingReceiver/MergingReceiverPOP/
- Implement basic merging POP config and creator
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingReceiverGeneratorBase.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingReceiverTemplate.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
PRE-CREATION
exec/java-exec/src/test/resources/mergerecv/merging_receiver.json
PRE-CREATION
Diff: https://reviews.apache.org/r/14958/diff/
Testing
-------
Thanks,
Ben Becker
