----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16241/ -----------------------------------------------------------
Review request for drill and Jacques Nadeau. Repository: drill-git Description ------- In FunctionRegistry (createByOp) while creating a logical expression for the operator we were using the entire list of arguments instead of using two at a time. For example while performing an 'add' with three numbers, instead of creating a logical expression with the first two inputs, which would be input to another logical expression along with the third input, we were creating a single logical expression with three inputs. In this case we would try and find a function implementation for add with three inputs and fail. Minor modification to simply use the two arguments at a time and create the appropriate logical expression tree. Diffs ----- common/src/main/java/org/apache/drill/common/expression/FunctionRegistry.java 73e1925 exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestMultiInputAdd.java PRE-CREATION exec/java-exec/src/test/resources/functions/multi_input_add_test.json PRE-CREATION Diff: https://reviews.apache.org/r/16241/diff/ Testing ------- Added test that performs addition with four inputs. Thanks, Mehant Baid
