Jason Altekruse created DRILL-340:
-------------------------------------

             Summary: Ensure methods intended to create new copies of plan 
nodes are actually creating copies of all nested objects
                 Key: DRILL-340
                 URL: https://issues.apache.org/jira/browse/DRILL-340
             Project: Apache Drill
          Issue Type: Bug
            Reporter: Jason Altekruse


Methods such as getNewWithChildren declared in the PhysicalOperator interface 
are designed to create copies of plan nodes. These copy operations should not 
reference any part of the old nodes, thus child objects should be deep copied, 
including lists of objects. For more information on the desired functionality 
see here: http://en.wikipedia.org/wiki/Clone_(Java_method)

Existing implementations should be checked for correctness. We may want to 
create this functionality for logical operators as well, but I do not believe 
that we should need to do manipulations on logical plans that would require it. 
Our optimization of plans will happen in the logical to physical plan 
transformation.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to