----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17035/#review32128 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/memory/AccountingByteBuf.java <https://reviews.apache.org/r/17035/#comment60812> Is the comment suggesting a TODO? it looks like it's just throwing UnsupportedOperation in the end anyways. exec/java-exec/src/main/java/org/apache/drill/exec/memory/AccountingByteBuf.java <https://reviews.apache.org/r/17035/#comment60813> Shouldn't take the endianness into account? exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java <https://reviews.apache.org/r/17035/#comment60814> Unused? same as the next constant exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java <https://reviews.apache.org/r/17035/#comment60817> I'm scanning files in the order in this reviewboard, so maybe I don't have all the context yet, but why we don't try to use parent allocator when there is no preallocated memory but we do that when there is? exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java <https://reviews.apache.org/r/17035/#comment60816> remove exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java <https://reviews.apache.org/r/17035/#comment60818> Don't you need to also return the unaccount size you allocated from parent too? exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java <https://reviews.apache.org/r/17035/#comment60819> Doesn't seem like you always allocate from parent (ie: when no preallocated) - Timothy Chen On Jan. 17, 2014, 5:51 a.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17035/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 5:51 a.m.) > > > Review request for drill. > > > Bugs: 334 > https://issues.apache.org/jira/browse/334 > > > Repository: drill-git > > > Description > ------- > > Drill 334 > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/config/DrillConfig.java > ffbf910 > exec/bufferl/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBufL.java > e5e1d20 > exec/java-exec/pom.xml 2ffdae9 > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > 465813c > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedCache.java > aed6cc2 > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMap.java > b7595f9 > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMultiMap.java > 886f122 > exec/java-exec/src/main/java/org/apache/drill/exec/cache/HazelCache.java > 9dd4373 > exec/java-exec/src/main/java/org/apache/drill/exec/cache/LocalCache.java > e6275c1 > exec/java-exec/src/main/java/org/apache/drill/exec/cache/ProtoBufImpl.java > d03eac8 > exec/java-exec/src/main/java/org/apache/drill/exec/cache/ProtoBufWrap.java > 448eecd > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java > 656d07f > exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java > 8ee9042 > exec/java-exec/src/main/java/org/apache/drill/exec/client/DumpCat.java > ef0b1e1 > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/AccountingByteBuf.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/BufferAllocator.java > 1584092 > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/DirectBufferAllocator.java > 77a251d > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/OutOfMemoryException.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/metrics/SingleThreadNestedCounter.java > 01385cf > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java > f75cf5f > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorStats.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java > c4cbf09 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedPartitionSender.java > 48412a0 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java > 2dc5f16 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java > ce0e15f > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java > d02396b > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java > 1d1d420 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WireRecordBatch.java > 6a16367 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java > 65cadb5 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/filter/FilterRecordBatch.java > d1f2e68 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatchBuilder.java > b07711e > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java > 712af9f > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java > f1bae15 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java > f120233 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/OutgoingRecordBatch.java > 081b4c2 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java > 409a9c3 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortBatch.java > e01fb74 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortRecordBatchBuilder.java > cb55a01 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/CopierTemplate2.java > a8b1eec > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/CopierTemplate4.java > ea35272 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java > 663f4c3 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/trace/TraceRecordBatch.java > c138aba > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/IteratorValidatorBatchIterator.java > d6f08f1 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java > 8262691 > > exec/java-exec/src/main/java/org/apache/drill/exec/proto/helper/QueryIdHelper.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java > ec2d246 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java > 1639940 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/FragmentWritableBatch.java > 41ad8b7 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/HyperVectorWrapper.java > d6d49c9 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java > 7497475 > exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatch.java > c13838c > > exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java > f19184f > > exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java > 462c00a > > exec/java-exec/src/main/java/org/apache/drill/exec/record/WritableBatch.java > 945df41 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java > 6ff6cf2 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java > 4533cc2 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java > 066af06 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClientWithConnection.java > df8638b > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java > a947f0a > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/CoordinationQueue.java > 6e1cf79 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/FutureBitCommand.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ListeningCommand.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java > 657b350 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ResettableBarrier.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/Response.java > b65e756 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcBus.java 3f31431 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcCommand.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcExceptionHandler.java > d0a8086 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ZeroCopyProtobufLengthDecoder.java > cff1a90 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/AvailabilityListener.java > ff3a032 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitClient.java > 7ada32c > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitCom.java > b3bff9f > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitComDefaultInstanceHandler.java > af3b10a > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitComImpl.java > 0078b07 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitCommand.java > 90cbf93 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitConnection.java > 97b5a79 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitConnectionManager.java > 6c6b6a0 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitRpcConfig.java > 8551357 > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitServer.java > 049418c > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitTunnel.java > bbeb39d > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/ConnectionManagerRegistry.java > af8fd9c > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/FutureBitCommand.java > f6c2660 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/ListenerPool.java > 1f85625 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/ListeningBitCommand.java > fa036b6 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/SendProgress.java > b26adb1 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/AvailabilityListener.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ConnectionManagerRegistry.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlCommand.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnection.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnectionManager.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlProtobufLengthDecoder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlRpcConfig.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlServer.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlTunnel.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/Controller.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/DefaultInstanceHandler.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/SendProgress.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/BitServerConnection.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClientConnection.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionManager.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataDefaultInstanceHandler.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataProtobufLengthDecoder.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataResponseHandler.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataResponseHandlerImpl.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataRpcConfig.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/SendProgress.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java > 392a168 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserProtobufLengthDecoder.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java > b973be9 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java > 225bd0b > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java > 49732d7 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java > 4656590 > > exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java > 8406deb > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordReader.java > 491779a > exec/java-exec/src/main/java/org/apache/drill/exec/util/AssertionUtil.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/util/AtomicState.java > f6653bc > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java > aa2826f > > exec/java-exec/src/main/java/org/apache/drill/exec/work/AbstractFragmentRunnerListener.java > 58b6d08 > exec/java-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/work/FragmentRunner.java > d003972 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/FragmentRunnerListener.java > 9188735 > exec/java-exec/src/main/java/org/apache/drill/exec/work/QueryWorkUnit.java > f001012 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/RemoteFragmentRunnerListener.java > da81399 > exec/java-exec/src/main/java/org/apache/drill/exec/work/StatusProvider.java > 3ddd2ac > exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java > 9a82c62 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/AbstractDataCollector.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/AbstractFragmentCollector.java > 7023373 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BatchCollector.java > 539393c > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BitComHandler.java > 1168659 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BitComHandlerImpl.java > 5d20026 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlHandlerImpl.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/DataCollector.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/IncomingBuffers.java > 992d9a9 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/MergingCollector.java > 1c92bbb > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/PartitionedCollector.java > f998eff > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/RawBatchBuffer.java > e7d3d06 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/SpoolingRawBatchBuffer.java > fa20b3d > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.java > 64012c6 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/ErrorHelper.java > 26ecc3b > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 726539a > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentStatusListener.java > 2fbb708 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/RootStatusReporter.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/RunningFragmentManager.java > 2cb57dd > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/TunnelManager.java > 9307034 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/AbstractStatusReporter.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentManager.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/IncomingFragmentHandler.java > a29c600 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/LocalFragmentHandler.java > 12a7501 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/NonRootFragmentManager.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/NonRootStatusReporter.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RemoteFragmentHandler.java > 6157229 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/StatusReporter.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/user/UserWorker.java > 6f2d85a > exec/java-exec/src/main/resources/drill-module.conf b84c406 > exec/java-exec/src/test/java/org/apache/drill/exec/client/DumpCatTest.java > c06818d > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestRepeatedFunction.java > 8f56464 > > exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestEndianess.java > 885de49 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/SimpleRootExec.java > 0312863 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestCastFunctions.java > e51bee7 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestComparisonFunctions.java > ea0ac2c > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestImplicitCastFunctions.java > d1e1fe2 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java > 99ab362 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java > d92d9fa > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestAgg.java > 89f3292 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestSimpleFilter.java > 5429bcf > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoin.java > 0120c7e > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java > d82c0e8 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/mergereceiver/TestMergingReceiver.java > 2b46f80 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/orderedpartitioner/TestOrderedPartitionExchange.java > d35a09e > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/project/TestSimpleProjection.java > fa67e06 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/sort/TestSimpleSort.java > a5837ed > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/TestSVRemover.java > b53d1d3 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/trace/TestTraceMultiRecordBatch.java > 11aae2f > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/trace/TestTraceOutputDump.java > 10ce997 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java > 836f177 > > exec/java-exec/src/test/java/org/apache/drill/exec/pop/TestFragmentChecker.java > 6e0bfa3 > > exec/java-exec/src/test/java/org/apache/drill/exec/record/vector/TestLoad.java > 4c45960 > > exec/java-exec/src/test/java/org/apache/drill/exec/record/vector/TestValueVector.java > cc4279d > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java > eaf6f5d > > exec/java-exec/src/test/java/org/apache/drill/exec/store/JSONRecordReaderTest.java > 0b134ca > exec/java-exec/src/test/resources/logback.xml dd32405 > protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java > PRE-CREATION > protocol/src/main/java/org/apache/drill/exec/proto/BitData.java > PRE-CREATION > protocol/src/main/java/org/apache/drill/exec/proto/CoordinationProtos.java > 01b8889 > protocol/src/main/java/org/apache/drill/exec/proto/ExecProtos.java 2ec2683 > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java > 60dd6fd > protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java e505204 > > protocol/src/main/java/org/apache/drill/exec/proto/helper/QueryIdHelper.java > 749b3d5 > protocol/src/main/protobuf/BitControl.proto PRE-CREATION > protocol/src/main/protobuf/BitData.proto PRE-CREATION > protocol/src/main/protobuf/Coordination.proto 5cc5cab > protocol/src/main/protobuf/ExecutionProtos.proto 7501d7c > protocol/src/main/protobuf/User.proto cbf5b4c > protocol/src/main/protobuf/UserBitShared.proto 0d98797 > sqlparser/src/main/java/org/apache/drill/optiq/DrillOptiq.java 1245cfe > > Diff: https://reviews.apache.org/r/17035/diff/ > > > Testing > ------- > > > Thanks, > > Jason Altekruse > >
