----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17165/#review32619 -----------------------------------------------------------
exec/bufferl/src/test/java/io/netty/buffer/TestPoolChunkTrim.java <https://reviews.apache.org/r/17165/#comment61514> Can you please break these into separate @Test methods for each individual test. That way, if we break multiple in the future we'll immediately know which one we broke. - Jacques Nadeau On Jan. 22, 2014, 10:36 p.m., John Morris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17165/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 10:36 p.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > Modified the netty direct memory manager to: > 1) Efficiently reduce ("trim") the size of a memory buffer, releasing the > extra memory back to the memory manager. > 2) Opportunistically allocate larger buffers if it can be done > efficiently. > 3) Raise a warning exception if resizing a buffer copies more than 1 page > of data. > 4) Added Javadocs and some in-code comments. > 5) Created a Junit test to verify basic functionality. > > The "trim" and allocation changes are primarily in PoolChunkL, > which breaks a "chunk" into runs of pages using a buddy system. > > > Diffs > ----- > > exec/bufferl/src/main/java/io/netty/buffer/PoolArenaL.java cd9ec3f > exec/bufferl/src/main/java/io/netty/buffer/PoolChunkL.java 91a13a9 > exec/bufferl/src/main/java/io/netty/buffer/PoolChunkListL.java cfa6fc6 > exec/bufferl/src/main/java/io/netty/buffer/PoolSubpageL.java 2956dd6 > exec/bufferl/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java > f3b3afb > exec/bufferl/src/main/java/io/netty/buffer/PooledByteBufL.java 595cbc9 > exec/bufferl/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBufL.java > e5e1d20 > exec/bufferl/src/main/java/io/netty/buffer/package-info.java PRE-CREATION > exec/bufferl/src/test/java/io/netty/buffer/TestPoolChunkTrim.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/17165/diff/ > > > Testing > ------- > > Created a basic Junit test to verify the functionality as well as some of the > boundary conditions. > > > Thanks, > > John Morris > >
