[
https://issues.apache.org/jira/browse/DRILL-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910970#comment-13910970
]
Jacques Nadeau commented on DRILL-362:
--------------------------------------
I don't think we need to change the proto files. You could simply apply a
filter to the proto files before generating your C code. No reason to change
the Java code since proto is a wire format.
> Some protobuf enum values generates problematic C++/Windows code
> ----------------------------------------------------------------
>
> Key: DRILL-362
> URL: https://issues.apache.org/jira/browse/DRILL-362
> Project: Apache Drill
> Issue Type: Bug
> Reporter: George Chow
> Priority: Minor
>
> The enums DataMode and MinorType (in Types.proto) each contain a value
> (OPTIONAL and NULL respectively) that generate into problematic C++ code on
> Windows under Visual Studio.
> I propose to add a prefix to the enum values to uniquify them. For example:
> enum DataMode {
> DM_OPTIONAL = 0,
> DM_REQUIRED = 1,
> DM_REPEATED = 2
> }
> This is slightly ugly but is ultimately safe. Unfortunately, this change will
> trigger a lot of little changes throughout the codebase.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
