----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18882/#review36491 -----------------------------------------------------------
Ship it! Ship It! exec/java-exec/src/main/java/org/apache/drill/exec/util/VectorUtil.java <https://reviews.apache.org/r/18882/#comment67476> I was thinking that you should quote and escape string values. Can you verify the expected output value formatting so we can make sure to get what test wants? - Jacques Nadeau On March 7, 2014, 7:58 p.m., Steven Phillips wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18882/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 7:58 p.m.) > > > Review request for drill. > > > Bugs: DRILL-396 > https://issues.apache.org/jira/browse/DRILL-396 > > > Repository: drill-git > > > Description > ------- > > DRILL-396 Enhance QuerySubmitter to support csv and tsv output formats. Also > added support for specifying multiple queries, as well as specifying query > from command line. > > Standardize command line options > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/client/QuerySubmitter.java > b07b3aee71f3d4aa6b6e48bfc55008a10ee9d874 > exec/java-exec/src/main/java/org/apache/drill/exec/util/VectorUtil.java > 553e50d002bb5e04c643e1c8682808fc568561a0 > > Diff: https://reviews.apache.org/r/18882/diff/ > > > Testing > ------- > > > Thanks, > > Steven Phillips > >
