----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18388/#review37429 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java <https://reviews.apache.org/r/18388/#comment68952> It wasn't clear whether the drillOptions in the plan properties contains all the options or just the ones set specifically in the session. I would assume that it is the latter ..such that if there are say total 100 options but the session is explicitly setting 2 of them, we don't need to propagate the default values of all 100 through each plan. Is that the case ? - Aman Sinha On Feb. 22, 2014, 12:44 a.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18388/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2014, 12:44 a.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > https://issues.apache.org/jira/browse/DRILL-381 > > This patch creates adds a storage system for Drill options. Currently only > the session options are working correctly. > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/logical/PlanProperties.java > 5980bf8 > > exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java > 875e8b6 > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java > 256e772 > exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java > 6e58ec7 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java > ec7244a > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java > 2e2d7fd > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OptionValueReader.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OptionValueReaderBatch.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OptionValueReaderCreator.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java > 0f45dbe > > exec/java-exec/src/main/java/org/apache/drill/exec/server/DistributedGlobalOptions.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillOptions.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java > 6400c75 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java > 39821e3 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > e4f8e7b > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java > 2dd8611 > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java > PRE-CREATION > exec/java-exec/src/test/resources/server/options_session_check.json > PRE-CREATION > exec/java-exec/src/test/resources/server/options_set.json PRE-CREATION > > Diff: https://reviews.apache.org/r/18388/diff/ > > > Testing > ------- > > > Thanks, > > Jason Altekruse > >
