----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18841/#review37600 -----------------------------------------------------------
Doing first pass while trying to understand the flow. Looks good so far with few comments. contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java <https://reviews.apache.org/r/18841/#comment69336> nit: There are many unused imports in some source files. contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java <https://reviews.apache.org/r/18841/#comment69344> Set the scanner caching to a non-default (1) value. Probably equal to record batch size? contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java <https://reviews.apache.org/r/18841/#comment69340> Throw a (subclass of) DrillRuntimeException? contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java <https://reviews.apache.org/r/18841/#comment69338> result.raw() has been deprecated in 0.96 and later. contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java <https://reviews.apache.org/r/18841/#comment69339> result.getBytes() does not exist in 0.96 and later. contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java <https://reviews.apache.org/r/18841/#comment69343> Use org.apache.hadoop.hbase.util.Bytes.compareTo(byte[], int, int, byte[], int, int) instead. It uses faster Unsafe based comparer. contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java <https://reviews.apache.org/r/18841/#comment69341> Did you mean setNull(i)? distribution/src/resources/drill-config.sh <https://reviews.apache.org/r/18841/#comment69214> Include HBase conf folder at the beginning of HBASE_CLASSPATH. - Aditya Kishore On March 6, 2014, 1:24 a.m., Steven Phillips wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18841/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 1:24 a.m.) > > > Review request for drill. > > > Bugs: DRILL-88 > https://issues.apache.org/jira/browse/DRILL-88 > > > Repository: drill-git > > > Description > ------- > > DRILL-88 HBase storage engine > > > Start HBase storage engine. > > > Diffs > ----- > > contrib/storage-hbase/pom.xml 7860ea5e7bbf884b4590021ed3024d25b9d8ed7d > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java > PRE-CREATION > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java > PRE-CREATION > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseScanBatchCreator.java > PRE-CREATION > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java > PRE-CREATION > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java > PRE-CREATION > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePluginConfig.java > PRE-CREATION > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSubScan.java > PRE-CREATION > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HTableReadEntry.java > PRE-CREATION > contrib/storage-hbase/src/main/resources/drill-module.conf PRE-CREATION > > contrib/storage-hbase/src/test/java/org/apache/drill/hbase/HBaseRecordReaderTest.java > PRE-CREATION > > contrib/storage-hbase/src/test/java/org/apache/drill/hbase/HBaseTestsSuite.java > PRE-CREATION > > contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestTableGenerator.java > PRE-CREATION > contrib/storage-hbase/src/test/resources/hbase-site.xml PRE-CREATION > > contrib/storage-hbase/src/test/resources/hbase/hbase_scan_screen_physical.json > PRE-CREATION > > contrib/storage-hbase/src/test/resources/hbase/hbase_scan_screen_physical_column_select.json > PRE-CREATION > > contrib/storage-hbase/src/test/resources/hbase/hbase_scan_screen_physical_family_select.json > PRE-CREATION > contrib/storage-hbase/src/test/resources/logback.xml PRE-CREATION > distribution/pom.xml ffbac0f3a9851fc6d05c9d4b0d5b029558ce267b > distribution/src/assemble/bin.xml 4e37c6a9053e827cc800b3e2ebeb491c3a2c67fb > distribution/src/resources/drill-config.sh > 7be5badea76771f5d9a20cc7bb674be6d277eba5 > distribution/src/resources/runbit 85daf8742ab559fe6588a2fd013ea2117e55bbd3 > distribution/src/resources/sqlline c526f03213cd438efce36332ca04f8dc1b4a390b > distribution/src/resources/submit_plan > 3c9184a00762a965e0006a1a296908b7796cf8eb > exec/java-exec/src/main/codegen/templates/NullableValueVectors.java > 051c62d213451fd9973c47b052cc9fc0ee188d6a > exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java > 5cd83afecc24a1fba3d5b566d565d460235e5e63 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java > f76e59a6ec3efd897e083ea4a755971a4fedcf13 > exec/java-exec/src/test/resources/sender/hash_exchange.json > fc45ec19b196ec8d61e5971cf3338ae93015638c > > Diff: https://reviews.apache.org/r/18841/diff/ > > > Testing > ------- > > > Thanks, > > Steven Phillips > >
