> On March 28, 2014, 9:25 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/ConvertToBigIntBE.java, > > line 43 > > <https://reviews.apache.org/r/19723/diff/3/?file=539647#file539647line43> > > > > In all places like this, you need to wrap the buffer with > > SwappedByteBuf as Drill buffers are always little endian but Unpooled > > returns a big endian. We'll have a better fix for this soon.
Fixed in updated patch. > On March 28, 2014, 9:25 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java, > > line 45 > > <https://reviews.apache.org/r/19723/diff/3/?file=539650#file539650line45> > > > > Can you add to the test a check that convert_from and convert_to by > > themselves works as expected. I think that right now (with the buffer > > endianness issue above), that they will not. Will add more tests in next patch. - Aditya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19723/#review38899 ----------------------------------------------------------- On March 28, 2014, 3:31 a.m., Aditya Kishore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19723/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 3:31 a.m.) > > > Review request for drill, Jacques Nadeau, Steven Phillips, and Venki > Korukanti. > > > Bugs: DRILL-452 > https://issues.apache.org/jira/browse/DRILL-452 > > > Repository: drill-git > > > Description > ------- > > This patch provides the foundation for drill convert_to() and convert_from() > functions along with couple of implementations. > > > Diffs > ----- > > > common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprLexer.g > be2a3f2 > > common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprParser.g > b60e2d6 > > common/src/main/java/org/apache/drill/common/expression/ConvertExpression.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java > 80fd41b > > common/src/main/java/org/apache/drill/common/expression/FunctionCallFactory.java > c6c7074 > > common/src/main/java/org/apache/drill/common/expression/visitors/AbstractExprVisitor.java > 727a3dc > > common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java > 630d00a > > common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java > 60e997f > > common/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java > e199f21 > > common/src/main/java/org/apache/drill/common/expression/visitors/ExpressionValidator.java > 96666bd > common/src/main/java/org/apache/drill/common/types/Types.java fd8991d > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java > e476897 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java > 8dfba76 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java > f764d32 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/ConvertFromBigIntBE.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/ConvertFromIntBE.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/ConvertToBigIntBE.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/ConvertToIntBE.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java > 5bd520d > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java > PRE-CREATION > exec/java-exec/src/test/resources/functions/conv/test_int_be.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/19723/diff/ > > > Testing > ------- > > * Existing Drill unit test suit. > * New test case TestConvertFunctions. > > > Thanks, > > Aditya Kishore > >
