Expression string builder bug, JODA cannot handle white space
Project: http://git-wip-us.apache.org/repos/asf/incubator-drill/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-drill/commit/2faf6ef0 Tree: http://git-wip-us.apache.org/repos/asf/incubator-drill/tree/2faf6ef0 Diff: http://git-wip-us.apache.org/repos/asf/incubator-drill/diff/2faf6ef0 Branch: refs/heads/master Commit: 2faf6ef0253d6d3a8e3ce4d34ccc96c5a8590a74 Parents: 8c51248 Author: Steven Phillips <[email protected]> Authored: Mon Mar 31 16:19:49 2014 -0700 Committer: Jacques Nadeau <[email protected]> Committed: Sat Apr 19 18:07:09 2014 -0700 ---------------------------------------------------------------------- .../apache/drill/common/expression/ExpressionStringBuilder.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-drill/blob/2faf6ef0/common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java ---------------------------------------------------------------------- diff --git a/common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java b/common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java index 35835c7..4bbc09a 100644 --- a/common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java +++ b/common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java @@ -136,7 +136,7 @@ public class ExpressionStringBuilder extends AbstractExprVisitor<Void, StringBui public Void visitIntervalYearConstant(IntervalYearExpression lExpr, StringBuilder sb) throws RuntimeException { sb.append("cast( \""); sb.append(Period.years(lExpr.getIntervalYear()).toString()); - sb.append(" \" as INTERVAL)"); + sb.append("\" as INTERVAL)"); return null; } @@ -144,7 +144,7 @@ public class ExpressionStringBuilder extends AbstractExprVisitor<Void, StringBui public Void visitIntervalDayConstant(IntervalDayExpression lExpr, StringBuilder sb) throws RuntimeException { sb.append("cast( \""); sb.append(Period.days(lExpr.getIntervalDay()).plusMillis(lExpr.getIntervalMillis()).toString()); - sb.append(" \" as INTERVAL)"); + sb.append("\" as INTERVAL)"); return null; }
