-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21003/
-----------------------------------------------------------

Review request for drill and Jinfeng Ni.


Bugs: DRILL-549
    https://issues.apache.org/jira/browse/DRILL-549


Repository: drill-git


Description
-------

The associated JIRA has the exhaustive list of functions that are implemented 
as part of this patch. 

Originally this review was on github, link to pull request to look at the 
review comments: https://github.com/apache/incubator-drill/pull/52


Diffs
-----

  exec/java-exec/src/main/codegen/config.fmpp 49e0614 
  exec/java-exec/src/main/codegen/data/DateIntervalFunc.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/data/ExtractTypes.tdd 70d7861 
  exec/java-exec/src/main/codegen/data/IntervalNumericTypes.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/CastVarCharDate.java ab846c0 
  
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateDateArithmeticFunctions.java
 PRE-CREATION 
  
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateIntervalArithmeticFunctions.java
 PRE-CREATION 
  
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateToCharFunctions.java
 PRE-CREATION 
  
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/Extract.java
 PRE-CREATION 
  
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/IntervalIntervalArithmetic.java
 PRE-CREATION 
  
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/IntervalNumericArithmetic.java
 PRE-CREATION 
  
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/ToDateTypeFunctions.java
 PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/Extract.java bef0614 
  exec/java-exec/src/main/codegen/templates/FixedValueVectors.java cba9f97 
  
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastBigIntDate.java
 e2586d8 
  
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastBigIntTimeStamp.java
 ea92f3c 
  
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastBigIntTimeStampTZ.java
 PRE-CREATION 
  
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CastIntTime.java
 PRE-CREATION 
  
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
 3d75048 
  
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateUtility.java
 c9e66a1 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 
ddc5025 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java
 2560302 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
 f46f012 
  
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
 PRE-CREATION 
  
exec/java-exec/src/test/resources/functions/date/date_difference_arithmetic.json
 PRE-CREATION 
  
exec/java-exec/src/test/resources/functions/date/date_interval_arithmetic.json 
PRE-CREATION 
  exec/java-exec/src/test/resources/functions/date/interval_arithmetic.json 
PRE-CREATION 
  exec/java-exec/src/test/resources/functions/date/to_char.json PRE-CREATION 
  exec/java-exec/src/test/resources/functions/date/to_date_type.json 
PRE-CREATION 
  protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java f91a010 
  protocol/src/main/protobuf/BitControl.proto 25cae11 

Diff: https://reviews.apache.org/r/21003/diff/


Testing
-------

Added unit tests in TestDateFunctions.


Thanks,

Mehant Baid

Reply via email to