----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21038/#review42209 -----------------------------------------------------------
Ship it! Ship It! - Steven Phillips On May 2, 2014, 10:30 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21038/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 10:30 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Repository: drill-git > > > Description > ------- > > Enables dictionary encoding for varBinary and VarChar columns, saves a lot of > space when storing a limited dictionary of values. Also is the default > encoding exported out of impala which was making testing difficult. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ColumnDataReader.java > a890f1c > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ColumnReader.java > d5c88ef > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/NullableColumnReader.java > b6ae715 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/PageReadStatus.java > 67262f6 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordReader.java > 6e17fba > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/VarLenBinaryReader.java > 09d19a8 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/VarLengthColumnReaders.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java > 9ba94fa > > Diff: https://reviews.apache.org/r/21038/diff/ > > > Testing > ------- > > tested on a file exported from the pig storer in the parquet-mr package. > > > Thanks, > > Jason Altekruse > >
