----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22074/ -----------------------------------------------------------
Review request for drill, Jacques Nadeau and StevenWW StevenWW. Bugs: DRILL-865 https://issues.apache.org/jira/browse/DRILL-865 Repository: drill-git Description ------- This patch contains interface changes to AbstractRecordBatch, AbstractSingleRecordBatch. Changed next() method of every operator that implements AbstractRecordBatch to be named innerNext(). In AbstractRecordBatch we wrap the call to innerNext() with stats collection so each of of the operators themselves don't have to repeat the same piece of logic. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java 1c1a6d2 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java 1113af4 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java d2800bd exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java 5b61a82 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java 2ea9339 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java 121cfec exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java 648fd89 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java be5bf76 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java a0c439e exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java 74a3c90 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java 05a6724 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortBatch.java 375276e exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java 3f2e060 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java c27b3c8 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java d6cbbc4 exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java 53b223e exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java d897a78 Diff: https://reviews.apache.org/r/22074/diff/ Testing ------- Thanks, Mehant Baid