> On May 30, 2014, 7:25 a.m., Mehant Baid wrote: > > exec/java-exec/src/main/codegen/data/CovarTypes.tdd, line 18 > > <https://reviews.apache.org/r/21931/diff/1/?file=594986#file594986line18> > > > > This probably should be in AggrTypes3.tdd, it contains aggregate > > functions that use three workspace variables. You could use a separate java > > template to generate the actual code if you think its cleaner
I am planning to implement the stats functions in their respective tdd files. Like CovarTypes.tdd, CorrelationTypes.tdd etc. Maybe I should change the name 'aggrtypes' to covarTypes & correlationTypes resp. ? Does that seem Good? - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21931/#review44342 ----------------------------------------------------------- On May 27, 2014, 8:30 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21931/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 8:30 p.m.) > > > Review request for drill, Aditya Kishore, Mehant Baid, and Timothy Chen. > > > Repository: drill-git > > > Description > ------- > > Added implementation for Co-Variance sample and population aggregate function. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/config.fmpp 5c0d03b > exec/java-exec/src/main/codegen/data/CovarTypes.tdd PRE-CREATION > exec/java-exec/src/main/codegen/templates/CovarTypeFunctions.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunction.java > ffb372d > exec/java-exec/src/test/resources/covariance_input.json PRE-CREATION > exec/java-exec/src/test/resources/functions/test_covariance.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/21931/diff/ > > > Testing > ------- > > Yes. > $ mvn test -Dtest=TestAggregateFunction#testCovariance > > > Thanks, > > Yash Sharma > >
