> On May 15, 2014, 6:41 p.m., Aman Sinha wrote: > > common/src/main/java/org/apache/drill/common/logical/data/Window.java, > > lines 107-108 > > <https://reviews.apache.org/r/21371/diff/3/?file=579599#file579599line107> > > > > Is 'Within' implying the OVER clause ? We should support empty OVER > > clause .. for example: SELECT SUM(a1) OVER (). Basically, no PARTITION BY > > or ORDER BY is specified, so I want to do the aggregate over entire data > > set. > > Timothy Chen wrote: > Within is actually the PARTITION by expressions, so PARTITION BY X with > translate into Within [ NamedExpression("X") ] > > And what will the results looks like? For SUM it's just the same value > for each row right? > I'm a bit fuzzy what the Window function standards are, and have been > referring to Optiq's Parser Test to see what valid options there are.
This won't be possible as an existing bug in Optiq doesn't allow that syntax. Julian already has a fix in master but we won't be able to get it since we're on our own fork. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21371/#review43130 ----------------------------------------------------------- On June 3, 2014, 9:24 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21371/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 9:24 a.m.) > > > Review request for drill. > > > Bugs: DRILL-705 > https://issues.apache.org/jira/browse/DRILL-705 > > > Repository: drill-git > > > Description > ------- > > Currently only supports partitioning/ordering, not yet preceding or after > offsets > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/expression/CastExpression.java > 7e5eea096b53ede676abb4764631fd92805b4ad1 > > common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java > 4e9807f82dd7915bb1b1e71d70edad8a198fd42b > common/src/main/java/org/apache/drill/common/expression/IfExpression.java > d1df7f7eb68ab3cf58705dc811e889058e6dc603 > common/src/main/java/org/apache/drill/common/expression/NullExpression.java > c39e06aef3d1e3caaa9222f1133e9a39c910ff5d > > common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java > 48ab3b47c8554840f551e5dc3d4a7017c2d98b00 > > common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java > 2b136a0ae13f4618c879ed0bb1d0bfe31758e2c3 > > common/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java > d56a16a27f551b59d6b7569270b76f2716841057 > > common/src/main/java/org/apache/drill/common/logical/data/AbstractBuilder.java > 69cb4eb73ab71c6424752a1027ee190ee95104c4 > > common/src/main/java/org/apache/drill/common/logical/data/AbstractSingleBuilder.java > e733fddc554f462dadcc96e21db29191000f6ea1 > common/src/main/java/org/apache/drill/common/logical/data/Limit.java > 110204be8bac10b960013d8cc52d552c50f15995 > > common/src/main/java/org/apache/drill/common/logical/data/LogicalOperator.java > 531e6a6244b110a845833c5d94b2077df1f26460 > > common/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java > 69a1c3c5e7e9911fc6fe1cccb16f8e6fb50dc293 > > common/src/main/java/org/apache/drill/common/logical/data/NamedExpression.java > 4c006c609e281a03607101fb83ae368bd4e43200 > > common/src/main/java/org/apache/drill/common/logical/data/SingleInputOperator.java > 0a5015c15a1e9a9b6c3b092ca644ec425d142957 > common/src/main/java/org/apache/drill/common/logical/data/Window.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/logical/data/WindowFrame.java > 09524061601209bd0d322fabade3df4ebdcd07bd > > common/src/main/java/org/apache/drill/common/logical/data/visitors/AbstractLogicalVisitor.java > 0099bb9a8a29f6c7e23ff7f45a80a1d714cb3ddd > > common/src/main/java/org/apache/drill/common/logical/data/visitors/LogicalVisitor.java > 4bf9fbfcaac21ab077ce26993575f679010bf592 > exec/java-exec/src/main/codegen/data/AggrTypes1.tdd > d76d91362ba44c318da3b005ba3837ae0528bec6 > exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java > aa9aeab7af7d387cff9da57af69d3c9a5a9498fd > exec/java-exec/src/main/codegen/templates/TypeHelper.java > 5f24a3087b1fddcd5919bc908be21b8b053c1ce0 > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java > 489f62310e4e358ced39f016e348786fb767088d > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java > 1c012ab6129ae915eb57202700599671406dd4d8 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionConverter.java > 44210914d1b6f819716b366020d116c89e92587f > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionImplementationRegistry.java > e5c890eb81320ecb3affe67b74e900636296c480 > exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java > 624042e03fb8f7fc980405597266044fea832e41 > exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java > 24d9cfe528c4ef7d930f216a7428557d29ffe357 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java > 01071012a9aebc5861dde6c4a2306efd3319cfbf > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractSingle.java > 4b6499fcd76ad45b349861338d74ed35e27324a5 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperator.java > 4dd2aeff05de7973da6b43b31e9b8af7924ea727 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java > 7a1440a4b2d7321efa086cc07f2a45468fa8a733 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Limit.java > 0db58ecec0dc69840e1e51680cdd21e3b535c17b > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/WindowPOP.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java > 3e6def128034ccfce2dab38cef1ccff61553a104 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java > 5b61a826c5cdc3578fe688ad8e7dfcbf07a7bfc5 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/filter/FilterRecordBatch.java > fb0e03ba726c0d73e3cb3a9a6300579c46b6eac8 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitBatchCreator.java > ccbf755faa8f1332df68e34bee130c7a27f503e0 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java > 648fd89717592d18aaed55c8f3d6f719bcc75f5e > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java > 05a6724b312ee302e0b65efc161ae93b0811840a > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java > 3f2e06078d50ca028264ec8ef2d4bfe567fef5f1 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/trace/TraceRecordBatch.java > b012cec1d8a4d81ab6508de76147562fc2f9f75e > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameBatchCreator.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameRecordBatch.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFrameTemplate.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFramer.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/BatchGroup.java > a546852903b8283377ed25e0de4ff3226e69859e > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillWindowRelBase.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java > 6d720a7d1d3afba72109230f8642e8c7cc3b60f5 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillAggregateRel.java > fe5130ced1acfbe548b3af9b42d0cb80b7840faa > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillLimitRule.java > c3b0d00c6bddf52cb88307a49df2574b720a4806 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjIntoScan.java > 0dd9b9ebba42f63db594e36564be47c2665870ee > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRel.java > 7eca54e9b9a79f63d0b9df1bebc7400f46996028 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java > c07fee35d3895b6d7bfbbd30a108d58a9f6abb60 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRel.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrel.java > 376f3349c23177819b2e786e2fd40a3a44494edd > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java > 772b3b9322b58f2cfdc84ee73c3717caac3fad4b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlAggOperator.java > 26f5af223adfac9b53a3504cf2dd7de77133a73f > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java > eb2c89147ea8b9e3a09772c3aff06c99887cddfb > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java > b7d9bd7f3e70a8754f9ae6a56986c4ea7f99e432 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java > 29ed1ec9bec0d78b7cbf77f2f5ad8ccfdf90a262 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java > d6849f4cab0084a282945deb661b0cdc3f545d5b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java > 63db153ba4c8850be3c77433bc9696be085a5c01 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java > 8ce046344ece8e9d4219ad25f5a9efe6adbd842e > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowSchemasHandler.java > 2a6dc6a33e679e1ff7f657727f2bc4628ef984e3 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java > 6905c1773ffbbe1a97d92201ee06aa9e5ac4ed39 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java > 5fa592a13c0e8e12f04121e2302339d48189ad63 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java > 7be40cbe932efcf73586575ce611c4ce694308cb > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java > b362a20e149e7db5bf0687b970387f3dc160666c > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java > 30c7e433bef7f82794200026de17a05fca0009cf > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java > bbb3a7f81f92c02410c4c879b357b02f3cf418af > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowFiles.java > f882ba9652528f357a2714952c18415d6eaa04ba > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java > 34695d950bc6b5e4b6369e91cc854f4580816d51 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java > 26d4fa216334d128ab92fba7dddd5868443a9424 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java > 42a3914a7d103e4ccf04afd246bdc01e06aa683a > > exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java > d897a7893ab805cec1f50e809efd7b6d1e4bcc01 > > exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java > 3c674662f9cf2c6251a2d4e754606cc674749afb > exec/java-exec/src/main/java/org/apache/drill/exec/schema/Field.java > 14049efaa7b2684e3f537985ec42977bb1863657 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/NonRootFragmentManager.java > 84fb806ed50b056917774d6fa7dac5c5f8995e98 > exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java > 7be8cc5f7498980a06e50dadd42105537fc4fa84 > > exec/java-exec/src/test/java/org/apache/drill/exec/cache/TestCacheSerialization.java > 6375d6612b6331b1f8a70d43486fe959e01f4f51 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestUtils.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java > 0caf6d9e72e2f038fae7c788d9971d8248efe661 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java > PRE-CREATION > exec/java-exec/src/test/resources/window/mediumData.json PRE-CREATION > exec/java-exec/src/test/resources/window/oneKeyCount.json PRE-CREATION > exec/java-exec/src/test/resources/window/oneKeyCountData.json PRE-CREATION > exec/java-exec/src/test/resources/window/oneKeyCountMultiBatch.json > PRE-CREATION > exec/java-exec/src/test/resources/window/twoKeys.json PRE-CREATION > exec/java-exec/src/test/resources/window/twoKeysData.json PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java > 594e3ffa347ffaffe1164aedc8a6226705aad48c > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java > 30a7144521117969db119791b0cb0896763c0494 > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java > 088191c80743189ad40dbd5e4cef61569a649958 > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java > 2ec7ba9ac9856799e4c2bc740acef188937edef8 > protocol/src/main/protobuf/UserBitShared.proto > 9a3dd2af48585b91f4326f05f8074df7f841a02e > tools/drill-patch-review.py c067ae2d805fa45707401953bb040f1f062ba920 > > Diff: https://reviews.apache.org/r/21371/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
