> On June 19, 2014, 10:17 p.m., Aditya Kishore wrote: > > exec/java-exec/src/main/codegen/data/AggrBitwiseLogicalTypes.tdd, line 21 > > <https://reviews.apache.org/r/22383/diff/3/?file=612054#file612054line21> > > > > I believe that for Nullable input types, the output of bitwise > > operators should be Nullable as well.
Fixed Nullable types and Re-Indented code with space rather than tabs. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22383/#review46232 ----------------------------------------------------------- On June 18, 2014, 4:59 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22383/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 4:59 a.m.) > > > Review request for drill, Aditya Kishore, Mehant Baid, and Timothy Chen. > > > Repository: drill-git > > > Description > ------- > > Bit wise and logical Aggregate functions. > > bit_and(expression) > bit_or(expression) > bool_and(expression) > bool_or(expression) > every(expression) > > > Diffs > ----- > > > common/src/main/java/org/apache/drill/common/expression/fn/CastFunctions.java > b76708d > exec/java-exec/src/main/codegen/config.fmpp 5c0d03b > exec/java-exec/src/main/codegen/data/AggrBitwiseLogicalTypes.tdd > PRE-CREATION > exec/java-exec/src/main/codegen/data/Casts.tdd e49df93 > > exec/java-exec/src/main/codegen/templates/AggrBitwiseLogicalTypeFunctions.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanAggrFunctions.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewAggregateFunctions.java > PRE-CREATION > exec/java-exec/src/test/resources/functions/test_logical_aggr.json > PRE-CREATION > exec/java-exec/src/test/resources/logical_aggr_input.json PRE-CREATION > > Diff: https://reviews.apache.org/r/22383/diff/ > > > Testing > ------- > > Yes. > > $ mvn test -Dtest=TestNewAggregateFunctions#testBitwiseAggrFuncs > > > Thanks, > > Yash Sharma > >
