----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23941/ -----------------------------------------------------------
Review request for drill and Parth Chandra. Bugs: DRILL-1197 https://issues.apache.org/jira/browse/DRILL-1197 Repository: drill-git Description ------- - add trace logging for error handling. - use shutdown operation instead of less portable cancel operation in socket - return more detailed connection status for validate handshake - some bug fixes for time out It depends on DRILL-1021 and DRILL-1137 Diffs ----- contrib/native/client/src/clientlib/drillClient.cpp 10480b4 contrib/native/client/src/clientlib/drillClientImpl.hpp 2bf7b5c contrib/native/client/src/clientlib/drillClientImpl.cpp 6a29d88 contrib/native/client/src/clientlib/errmsgs.hpp 437335c contrib/native/client/src/clientlib/errmsgs.cpp 966cfc2 contrib/native/client/src/include/drill/common.hpp 2113ce5 contrib/native/client/src/include/drill/drillClient.hpp 6d59afb Diff: https://reviews.apache.org/r/23941/diff/ Testing ------- Test case: 1. handshake phase. Run a listening port (say port 1234) and set timeout to 5. $ nc -l 1234 2. query phase. Run a query like TPCH-12 and set the query timeout with 1 second. Thanks, Xiao Meng