----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23436/#review48780 -----------------------------------------------------------
Ship it! Ship It! - Parth Chandra On July 25, 2014, 7:37 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23436/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 7:37 p.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-1137 > https://issues.apache.org/jira/browse/DRILL-1137 > > > Repository: drill-git > > > Description > ------- > > Set the default schema in handshake message. Also update some code comments. > > querySubmitter is updated for testing. > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp 9d24e68 > contrib/native/client/src/clientlib/drillClient.cpp 10480b4 > contrib/native/client/src/clientlib/drillClientImpl.hpp 2bf7b5c > contrib/native/client/src/clientlib/drillClientImpl.cpp 6a29d88 > contrib/native/client/src/include/drill/drillClient.hpp 6d59afb > > Diff: https://reviews.apache.org/r/23436/diff/ > > > Testing > ------- > > Test Query > > {code} > ./querySubmitter connectStr="zk=127.0.0.1:2181/drill/drillbits1" type=sql > api=async query="select * from sys.drillbits" schema="sys" > {code} > > > Thanks, > > Xiao Meng > >
